Lint Report

Overview

	Lint
1	ObsoleteLintCustomCheck: Obsolete custom lint check
1	IidCompatibilityCheckFailure: Firebase IID Compatibility Check Unable To Run
	Correctness
14	InlinedApi: Using inlined constants on older versions
1	SimpleDateFormat: Implied locale in date format
2	UnusedAttribute: Attribute unused on older versions
9	InflateParams: Layout Inflation without a Parent
232	NonConstantResourceId: Checks use of resource IDs in places requiring constants.
1	SQLiteString: Using STRING instead of TEXT
1	UseSwitchCompatOrMaterialCode: Replace usage of `Switch` widget
3	VectorRaster: Vector Image Generation
1	SourceLockedOrientationActivity: Incompatible setRequestedOrientation value
	Security
1	AcceptsUserCertificates: Allowing User Certificates
4	ExportedService: Exported service does not require permission
1	InsecureBaseConfiguration: Insecure Base Configuration
	Performance
18	StaticFieldLeak: Static Field Leaks
1	HandlerLeak: Handler reference leaks
2	MergeRootFrame: FrameLayout can be replaced with `<merge>` tag
2	NestedWeights: Nested layout weights
5	Overdraw: Overdraw: Painting regions more than once
1	UsableSpace: Using getUsableSpace()
	Accessibility
3	ClickableViewAccessibility: Accessibility in Custom Views
6	KeyboardInaccessibleWidget: Keyboard inaccessible widget
	Internationalization
1	RelativeOverlap: Overlapping items in RelativeLayout
	Disabled Checks (43)

Obsolete custom lint check

../../../../../root/.gradle/caches/transforms-2/files-2.1/c0ab38c2f5aed4f1186ed0c0289328e5/appcompat-1.2.0/jars/lint.jar: Lint found an issue registry (androidx.appcompat.AppCompatIssueRegistry) which is older than the current API level; these checks may not work correctly.

Recompile the checks against the latest version. Custom check API version is 7 (4.0), current lint API level is 8 (4.1+)
Applies to variants: qaDebug
Does not apply to variants: genericDebug, genericRelease, gplayDebug, gplayRelease, qaRelease, versionDevDebug, versionDevRelease

ObsoleteLintCustomCheck Warning Priority 10/10

Firebase IID Compatibility Check Unable To Run

../../../../src: Check failed with exception: java.lang.NoSuchMethodException: com.android.tools.lint.detector.api.LintModelModuleProject.getGradleProjectModel()

IidCompatibilityCheckFailure Information Priority 1/10

Using inlined constants on older versions

../../../src/main/java/com/owncloud/android/datamodel/MediaProvider.java:55: Field requires API level 29 (current min is 19): android.provider.MediaStore.MediaColumns#BUCKET_ID

  52   // fixed query parameters
  53   private static final Uri IMAGES_MEDIA_URI = android.provider.MediaStore.Images.Media.EXTERNAL_CONTENT_URI;
  54   private static final String[] FILE_PROJECTION = new String[]{MediaStore.MediaColumns.DATA};
  55   private static final String IMAGES_FILE_SELECTION = MediaStore.Images.Media.BUCKET_ID + "=";    
  56   private static final String[] IMAGES_FOLDER_PROJECTION = {MediaStore.Images.Media.BUCKET_ID,
  57           MediaStore.Images.Media.BUCKET_DISPLAY_NAME};
  58   private static final String IMAGES_FOLDER_SORT_ORDER = MediaStore.Images.Media.BUCKET_DISPLAY_NAME + " ASC";

../../../src/main/java/com/owncloud/android/datamodel/MediaProvider.java:56: Field requires API level 29 (current min is 19): android.provider.MediaStore.MediaColumns#BUCKET_ID

  53   private static final Uri IMAGES_MEDIA_URI = android.provider.MediaStore.Images.Media.EXTERNAL_CONTENT_URI;
  54   private static final String[] FILE_PROJECTION = new String[]{MediaStore.MediaColumns.DATA};
  55   private static final String IMAGES_FILE_SELECTION = MediaStore.Images.Media.BUCKET_ID + "=";
  56   private static final String[] IMAGES_FOLDER_PROJECTION = {MediaStore.Images.Media.BUCKET_ID,    
  57           MediaStore.Images.Media.BUCKET_DISPLAY_NAME};
  58   private static final String IMAGES_FOLDER_SORT_ORDER = MediaStore.Images.Media.BUCKET_DISPLAY_NAME + " ASC";

../../../src/main/java/com/owncloud/android/datamodel/MediaProvider.java:57: Field requires API level 29 (current min is 19): android.provider.MediaStore.MediaColumns#BUCKET_DISPLAY_NAME

  54   private static final String[] FILE_PROJECTION = new String[]{MediaStore.MediaColumns.DATA};
  55   private static final String IMAGES_FILE_SELECTION = MediaStore.Images.Media.BUCKET_ID + "=";
  56   private static final String[] IMAGES_FOLDER_PROJECTION = {MediaStore.Images.Media.BUCKET_ID,
  57           MediaStore.Images.Media.BUCKET_DISPLAY_NAME};                                           
  58   private static final String IMAGES_FOLDER_SORT_ORDER = MediaStore.Images.Media.BUCKET_DISPLAY_NAME + " ASC";
  59 
  60   private static final String[] VIDEOS_FOLDER_PROJECTION = {MediaStore.Video.Media.BUCKET_ID,

../../../src/main/java/com/owncloud/android/datamodel/MediaProvider.java:58: Field requires API level 29 (current min is 19): android.provider.MediaStore.MediaColumns#BUCKET_DISPLAY_NAME

  55   private static final String IMAGES_FILE_SELECTION = MediaStore.Images.Media.BUCKET_ID + "=";
  56   private static final String[] IMAGES_FOLDER_PROJECTION = {MediaStore.Images.Media.BUCKET_ID,
  57           MediaStore.Images.Media.BUCKET_DISPLAY_NAME};
  58   private static final String IMAGES_FOLDER_SORT_ORDER = MediaStore.Images.Media.BUCKET_DISPLAY_NAME + " ASC";
  59 
  60   private static final String[] VIDEOS_FOLDER_PROJECTION = {MediaStore.Video.Media.BUCKET_ID,
  61           MediaStore.Video.Media.BUCKET_DISPLAY_NAME};

../../../src/main/java/com/owncloud/android/datamodel/MediaProvider.java:60: Field requires API level 29 (current min is 19): android.provider.MediaStore.MediaColumns#BUCKET_ID

  57           MediaStore.Images.Media.BUCKET_DISPLAY_NAME};
  58   private static final String IMAGES_FOLDER_SORT_ORDER = MediaStore.Images.Media.BUCKET_DISPLAY_NAME + " ASC";
  59 
  60   private static final String[] VIDEOS_FOLDER_PROJECTION = {MediaStore.Video.Media.BUCKET_ID,     
  61           MediaStore.Video.Media.BUCKET_DISPLAY_NAME};
  62 
  63   private MediaProvider() {

../../../src/main/java/com/owncloud/android/datamodel/MediaProvider.java:61: Field requires API level 29 (current min is 19): android.provider.MediaStore.MediaColumns#BUCKET_DISPLAY_NAME

  58   private static final String IMAGES_FOLDER_SORT_ORDER = MediaStore.Images.Media.BUCKET_DISPLAY_NAME + " ASC";
  59 
  60   private static final String[] VIDEOS_FOLDER_PROJECTION = {MediaStore.Video.Media.BUCKET_ID,
  61           MediaStore.Video.Media.BUCKET_DISPLAY_NAME};                                            
  62 
  63   private MediaProvider() {
  64       // utility class -> private constructor

../../../src/main/java/com/owncloud/android/datamodel/MediaProvider.java:91: Field requires API level 29 (current min is 19): android.provider.MediaStore.MediaColumns#DATE_TAKEN

  88   String dataPath = MainApp.getStoragePath() + File.separator + MainApp.getDataFolder();
  89 
  90   if (cursorFolders != null) {
  91       String fileSortOrder = MediaStore.Images.Media.DATE_TAKEN + " DESC LIMIT " + itemLimit; 
  92       Cursor cursorImages;
  93 
  94       Map<String, String> uniqueFolders = new HashMap<>();

../../../src/main/java/com/owncloud/android/datamodel/MediaProvider.java:99: Field requires API level 29 (current min is 19): android.provider.MediaStore.MediaColumns#BUCKET_ID

  96   // since sdk 29 we have to manually distinct on bucket id
  97   while (cursorFolders.moveToNext()) {
  98       uniqueFolders.put(cursorFolders.getString(
  99           cursorFolders.getColumnIndex(MediaStore.Images.Media.BUCKET_ID)),               
 100                         cursorFolders.getString(
 101                             cursorFolders.getColumnIndex(MediaStore.Images.Media.BUCKET_DISPLAY_NAME))
 102       );

../../../src/main/java/com/owncloud/android/datamodel/MediaProvider.java:101: Field requires API level 29 (current min is 19): android.provider.MediaStore.MediaColumns#BUCKET_DISPLAY_NAME

  98       uniqueFolders.put(cursorFolders.getString(
  99           cursorFolders.getColumnIndex(MediaStore.Images.Media.BUCKET_ID)),
 100                         cursorFolders.getString(
 101                             cursorFolders.getColumnIndex(MediaStore.Images.Media.BUCKET_DISPLAY_NAME))
 102       );
 103   }
 104   cursorFolders.close();

../../../src/main/java/com/owncloud/android/datamodel/MediaProvider.java:210: Field requires API level 29 (current min is 19): android.provider.MediaStore.MediaColumns#DATE_TAKEN

 207   String dataPath = MainApp.getStoragePath() + File.separator + MainApp.getDataFolder();
 208 
 209   if (cursorFolders != null) {
 210       String fileSortOrder = MediaStore.Video.Media.DATE_TAKEN + " DESC LIMIT " + itemLimit;  
 211       Cursor cursorVideos;
 212 
 213       Map<String, String> uniqueFolders = new HashMap<>();

../../../src/main/java/com/owncloud/android/datamodel/MediaProvider.java:218: Field requires API level 29 (current min is 19): android.provider.MediaStore.MediaColumns#BUCKET_ID

 215   // since sdk 29 we have to manually distinct on bucket id
 216   while (cursorFolders.moveToNext()) {
 217       uniqueFolders.put(cursorFolders.getString(
 218           cursorFolders.getColumnIndex(MediaStore.Video.Media.BUCKET_ID)),                
 219                         cursorFolders.getString(
 220                             cursorFolders.getColumnIndex(MediaStore.Video.Media.BUCKET_DISPLAY_NAME))
 221       );

../../../src/main/java/com/owncloud/android/datamodel/MediaProvider.java:220: Field requires API level 29 (current min is 19): android.provider.MediaStore.MediaColumns#BUCKET_DISPLAY_NAME

 217       uniqueFolders.put(cursorFolders.getString(
 218           cursorFolders.getColumnIndex(MediaStore.Video.Media.BUCKET_ID)),
 219                         cursorFolders.getString(
 220                             cursorFolders.getColumnIndex(MediaStore.Video.Media.BUCKET_DISPLAY_NAME))
 221       );
 222   }
 223   cursorFolders.close();

../../../src/main/java/com/owncloud/android/datamodel/MediaProvider.java:235: Field requires API level 29 (current min is 19): android.provider.MediaStore.MediaColumns#BUCKET_ID

 232                 cursorVideos = contentResolver.query(
 233                     MediaStore.Video.Media.EXTERNAL_CONTENT_URI,
 234                     FILE_PROJECTION,
 235                     MediaStore.Video.Media.BUCKET_ID + "=" + folder.getKey(),                       
 236                     null,
 237                     fileSortOrder);
 238                 Log.d(TAG, "Reading videos for " + mediaFolder.folderName);

../../../src/main/java/com/owncloud/android/datamodel/MediaProvider.java:260: Field requires API level 29 (current min is 19): android.provider.MediaStore.MediaColumns#BUCKET_ID

 257              Cursor count = contentResolver.query(
 258                  MediaStore.Video.Media.EXTERNAL_CONTENT_URI,
 259                  FILE_PROJECTION,
 260                  MediaStore.Video.Media.BUCKET_ID + "=" + folder.getKey(),               
 261                  null,
 262                  null);

This check scans through all the Android API field references in the application and flags certain constants, such as static final integers and Strings, which were introduced in later versions. These will actually be copied into the class files rather than being referenced, which means that the value is available even when running on older devices. In some cases that's fine, and in other cases it can result in a runtime crash or incorrect behavior. It depends on the context, so consider the code carefully and decide whether it's safe and can be suppressed or whether the code needs to be guarded.

If you really want to use this API and don't need to support older devices just set the minSdkVersion in your build.gradle or AndroidManifest.xml files.

If your code is deliberately accessing newer APIs, and you have ensured (e.g. with conditional execution) that this code will only ever be called on a supported platform, then you can annotate your class or method with the @TargetApi annotation specifying the local minimum SDK to apply, such as @TargetApi(11), such that this check considers 11 rather than your manifest file's minimum SDK as the required API level.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "InlinedApi" as explained in the Suppressing Warnings and Errors section.

InlinedApi Correctness Warning Priority 6/10

Implied locale in date format

../../../src/main/java/third_parties/ezvcard_android/ContactOperations.java:477: To get local formatting use getDateInstance(), getDateTimeInstance(), or getTimeInstance(), or use new SimpleDateFormat(String template, Locale locale) with for example Locale.US for ASCII dates.

 474     }
 475 
 476     private void convertBirthdays(List<NonEmptyContentValues> contentValues, VCard vcard) {
 477         DateFormat df = new SimpleDateFormat("yyyy-MM-dd");                                         
 478         for (Birthday birthday : vcard.getBirthdays()) {
 479             Date date = birthday.getDate();
 480             if (date == null) {

Almost all callers should use getDateInstance(), getDateTimeInstance(), or getTimeInstance() to get a ready-made instance of SimpleDateFormat suitable for the user's locale. The main reason you'd create an instance this class directly is because you need to format/parse a specific machine-readable format, in which case you almost certainly want to explicitly ask for US to ensure that you get ASCII digits (rather than, say, Arabic digits).

Therefore, you should either use the form of the SimpleDateFormat constructor where you pass in an explicit locale, such as Locale.US, or use one of the get instance methods, or suppress this error if really know what you are doing.

More info: https://developer.android.com/reference/java/text/SimpleDateFormat.html

To suppress this error, use the issue id "SimpleDateFormat" as explained in the Suppressing Warnings and Errors section.

SimpleDateFormat Correctness Warning Priority 6/10

Attribute unused on older versions

../../../src/main/res/layout/files_picker.xml:63: Attribute stateListAnimator is only used in API level 21 and higher (current min is 19)

 60             android:layout_height="wrap_content"
 61             android:layout_marginEnd="@dimen/standard_half_margin"
 62             android:layout_weight="1"
 63             android:stateListAnimator="@null"                                                       
 64             app:cornerRadius="@dimen/button_corner_radius"
 65             android:text="@string/common_cancel" />
 66     </LinearLayout>

../../../src/main/res/layout/list_item.xml:26: Attribute android:foreground has no effect on API levels lower than 23 (current min is 19)

  23     android:layout_height="@dimen/standard_list_item_size"
  24     android:baselineAligned="false"
  25     android:descendantFocusability="blocksDescendants"
  26     android:foreground="?android:attr/selectableItemBackground"                                     
  27     android:orientation="horizontal">
  28 
  29     <androidx.constraintlayout.widget.ConstraintLayout

This check finds attributes set in XML files that were introduced in a version newer than the oldest version targeted by your application (with the minSdkVersion attribute).

This is not an error; the application will simply ignore the attribute. However, if the attribute is important to the appearance or functionality of your application, you should consider finding an alternative way to achieve the same result with only available attributes, and then you can optionally create a copy of the layout in a layout-vNN folder which will be used on API NN or higher where you can take advantage of the newer attribute.

Note: This check does not only apply to attributes. For example, some tags can be unused too, such as the new <tag> element in layouts introduced in API 21.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "UnusedAttribute" as explained in the Suppressing Warnings and Errors section.

UnusedAttribute Correctness Warning Priority 6/10

Layout Inflation without a Parent

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactsBackupFragment.java:125: Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout's root element)

 122         if (ThemeUtils.themingEnabled(getContext())) {
 123             getContext().getTheme().applyStyle(R.style.FallbackThemingTheme, true);
 124         }
 125         View view = inflater.inflate(R.layout.contacts_backup_fragment, null);                      
 126         ButterKnife.bind(this, view);
 127 
 128         setHasOptionsMenu(true);

../../../src/main/java/com/owncloud/android/ui/fragment/ExtendedListFragment.java:360: Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout's root element)

 357   public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
 358       Log_OC.d(TAG, "onCreateView");
 359 
 360       View v = inflater.inflate(R.layout.list_fragment, null);                                    
 361       setupEmptyList(v);
 362 
 363       mRecyclerView = v.findViewById(R.id.list_root);

../../../src/main/java/com/owncloud/android/media/MediaControlView.java:78: Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout's root element)

  75           ViewGroup.LayoutParams.MATCH_PARENT
  76   );
  77   LayoutInflater inflate = (LayoutInflater) context.getSystemService(Context.LAYOUT_INFLATER_SERVICE);
  78   root = inflate.inflate(R.layout.media_control, null);                                       
  79   initControllerView(root);
  80   addView(root, frameParams);

../../../src/main/java/com/owncloud/android/ui/fragment/OCFileListBottomSheetDialog.java:109: Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout's root element)

 106   @Override
 107   protected void onCreate(Bundle savedInstanceState) {
 108       super.onCreate(savedInstanceState);
 109       final View view = getLayoutInflater().inflate(R.layout.file_list_actions_bottom_sheet_fragment, null);
 110       setContentView(view);
 111 
 112       if (getWindow() != null) {

../../../src/main/java/com/owncloud/android/ui/fragment/OCFileListBottomSheetDialog.java:150: Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout's root element)

 147   LayoutInflater vi = (LayoutInflater) getContext().getSystemService(Context.LAYOUT_INFLATER_SERVICE);
 148 
 149   for (Creator creator : directEditing.getCreators().values()) {
 150       View creatorView = vi.inflate(R.layout.file_list_actions_bottom_sheet_creator, null);
 151       ((TextView) creatorView.findViewById(R.id.creator_name)).setText(
 152           String.format(fileActivity.getString(R.string.editor_placeholder),
 153                         fileActivity.getString(R.string.create_new),

../../../src/main/java/com/owncloud/android/ui/activity/ReceiveExternalFilesActivity.java:358: Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout's root element)

  355   }
  356 
  357   LayoutInflater layout = LayoutInflater.from(requireContext());
  358   View view = layout.inflate(R.layout.upload_file_dialog, null);                          
  359 
  360   ArrayAdapter<String> adapter
  361           = new ArrayAdapter<>(requireContext(), android.R.layout.simple_spinner_item);

../../../src/main/java/com/owncloud/android/ui/dialog/SetupEncryptionDialogFragment.java:137: Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout's root element)

 134         LayoutInflater inflater = getActivity().getLayoutInflater();
 135 
 136         // Setup layout
 137         View v = inflater.inflate(R.layout.setup_encryption_dialog, null);                          
 138         textView = v.findViewById(R.id.encryption_status);
 139         passphraseTextView = v.findViewById(R.id.encryption_passphrase);
 140         passwordField = v.findViewById(R.id.encryption_passwordInput);

../../../src/main/java/com/owncloud/android/ui/dialog/SslValidatorDialog.java:98: Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout's root element)

  95     protected void onCreate(Bundle savedInstanceState) {
  96         super.onCreate(savedInstanceState);
  97         requestWindowFeature(Window.FEATURE_NO_TITLE);
  98         mView = getLayoutInflater().inflate(R.layout.ssl_validator_layout, null);                   
  99         setContentView(mView); 
 100         
 101         mView.findViewById(R.id.ok).setOnClickListener(

../../../src/main/java/com/owncloud/android/ui/adapter/UploaderAdapter.java:68: Avoid passing null as the view root (needed to resolve layout parameters on the inflated layout's root element)

  65     public View getView(int position, View convertView, ViewGroup parent) {
  66         View vi = convertView;
  67         if (convertView == null) {
  68             vi = inflater.inflate(R.layout.uploader_list_item_layout, null);                        
  69         }
  70 
  71         HashMap<String, OCFile> data = (HashMap<String, OCFile>) getItem(position);

InflateParams Correctness Warning Priority 5/10

Checks use of resource IDs in places requiring constants.

../../../src/main/java/com/owncloud/android/ui/activities/ActivitiesActivity.java:70: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  67     private static final String TAG = ActivitiesActivity.class.getSimpleName();
  68     private static final int UNDEFINED = -1;
  69 
  70     @BindView(R.id.empty_list_view)                                                                 
  71     public LinearLayout emptyContentContainer;
  72 
  73     @BindView(R.id.swipe_containing_list)

../../../src/main/java/com/owncloud/android/ui/activities/ActivitiesActivity.java:73: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  70     @BindView(R.id.empty_list_view)
  71     public LinearLayout emptyContentContainer;
  72 
  73     @BindView(R.id.swipe_containing_list)                                                           
  74     public SwipeRefreshLayout swipeListRefreshLayout;
  75 
  76     @BindView(R.id.empty_list_view_text)

../../../src/main/java/com/owncloud/android/ui/activities/ActivitiesActivity.java:76: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  73     @BindView(R.id.swipe_containing_list)
  74     public SwipeRefreshLayout swipeListRefreshLayout;
  75 
  76     @BindView(R.id.empty_list_view_text)                                                            
  77     public TextView emptyContentMessage;
  78 
  79     @BindView(R.id.empty_list_view_headline)

../../../src/main/java/com/owncloud/android/ui/activities/ActivitiesActivity.java:79: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  76     @BindView(R.id.empty_list_view_text)
  77     public TextView emptyContentMessage;
  78 
  79     @BindView(R.id.empty_list_view_headline)                                                        
  80     public TextView emptyContentHeadline;
  81 
  82     @BindView(R.id.empty_list_icon)

../../../src/main/java/com/owncloud/android/ui/activities/ActivitiesActivity.java:82: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  79     @BindView(R.id.empty_list_view_headline)
  80     public TextView emptyContentHeadline;
  81 
  82     @BindView(R.id.empty_list_icon)                                                                 
  83     public ImageView emptyContentIcon;
  84 
  85     @BindView(R.id.empty_list_progress)

../../../src/main/java/com/owncloud/android/ui/activities/ActivitiesActivity.java:85: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  82     @BindView(R.id.empty_list_icon)
  83     public ImageView emptyContentIcon;
  84 
  85     @BindView(R.id.empty_list_progress)                                                             
  86     public ProgressBar emptyContentProgressBar;
  87 
  88     @BindView(android.R.id.list)

../../../src/main/java/com/owncloud/android/ui/activities/ActivitiesActivity.java:91: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  88     @BindView(android.R.id.list)
  89     public RecyclerView recyclerView;
  90 
  91     @BindString(R.string.activities_no_results_headline)                                            
  92     public String noResultsHeadline;
  93 
  94     @BindString(R.string.activities_no_results_message)

../../../src/main/java/com/owncloud/android/ui/activities/ActivitiesActivity.java:94: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  91     @BindString(R.string.activities_no_results_headline)
  92     public String noResultsHeadline;
  93 
  94     @BindString(R.string.activities_no_results_message)                                             
  95     public String noResultsMessage;
  96 
  97     private ActivityListAdapter adapter;

../../../src/main/java/com/owncloud/android/ui/adapter/ActivityAndVersionListAdapter.java:172: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

 169     }
 170 
 171     protected class VersionViewHolder extends RecyclerView.ViewHolder {
 172         @BindView(R.id.size)                                                                        
 173         public TextView size;
 174         @BindView(R.id.time)
 175         public TextView time;

../../../src/main/java/com/owncloud/android/ui/adapter/ActivityAndVersionListAdapter.java:174: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

 171     protected class VersionViewHolder extends RecyclerView.ViewHolder {
 172         @BindView(R.id.size)
 173         public TextView size;
 174         @BindView(R.id.time)                                                                        
 175         public TextView time;
 176         @BindView(R.id.restore)
 177         public ImageView restore;

../../../src/main/java/com/owncloud/android/ui/adapter/ActivityAndVersionListAdapter.java:176: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

 173         public TextView size;
 174         @BindView(R.id.time)
 175         public TextView time;
 176         @BindView(R.id.restore)                                                                     
 177         public ImageView restore;
 178 
 179         VersionViewHolder(View itemView) {

../../../src/main/java/com/owncloud/android/ui/dialog/ChooseRichDocumentsTemplateDialogFragment.java:102: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  99         PRESENTATION
 100     }
 101 
 102     @BindView(R.id.list)                                                                            
 103     RecyclerView listView;
 104 
 105     @BindView(R.id.filename)

../../../src/main/java/com/owncloud/android/ui/dialog/ChooseRichDocumentsTemplateDialogFragment.java:105: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

 102     @BindView(R.id.list)
 103     RecyclerView listView;
 104 
 105     @BindView(R.id.filename)                                                                        
 106     EditText fileName;
 107 
 108     @NextcloudServer(max = 18) // will be removed in favor of generic direct editing

../../../src/main/java/com/owncloud/android/ui/dialog/ChooseTemplateDialogFragment.java:102: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  99         PRESENTATION
 100     }
 101 
 102     @BindView(R.id.list)                                                                            
 103     RecyclerView listView;
 104 
 105     @BindView(R.id.filename)

../../../src/main/java/com/owncloud/android/ui/dialog/ChooseTemplateDialogFragment.java:105: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

 102   @BindView(R.id.list)
 103   RecyclerView listView;
 104 
 105   @BindView(R.id.filename)                                                                        
 106   EditText fileName;
 107 
 108   public static ChooseTemplateDialogFragment newInstance(OCFile parentFolder, Creator creator) {

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactListFragment.java:122: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

 119 
 120     private static final int SINGLE_ACCOUNT = 1;
 121 
 122     @BindView(R.id.contactlist_recyclerview)                                                        
 123     public RecyclerView recyclerView;
 124 
 125     @BindView(R.id.contactlist_restore_selected_container)

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactListFragment.java:125: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

 122     @BindView(R.id.contactlist_recyclerview)
 123     public RecyclerView recyclerView;
 124 
 125     @BindView(R.id.contactlist_restore_selected_container)                                          
 126     public LinearLayout restoreContactsContainer;
 127 
 128     @BindView(R.id.contactlist_restore_selected)

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactListFragment.java:128: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

 125     @BindView(R.id.contactlist_restore_selected_container)
 126     public LinearLayout restoreContactsContainer;
 127 
 128     @BindView(R.id.contactlist_restore_selected)                                                    
 129     public Button restoreContacts;
 130 
 131     @BindView(R.id.empty_list_view_text)

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactListFragment.java:131: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

 128     @BindView(R.id.contactlist_restore_selected)
 129     public Button restoreContacts;
 130 
 131     @BindView(R.id.empty_list_view_text)                                                            
 132     public TextView emptyContentMessage;
 133 
 134     @BindView(R.id.empty_list_view_headline)

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactListFragment.java:134: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

 131     @BindView(R.id.empty_list_view_text)
 132     public TextView emptyContentMessage;
 133 
 134     @BindView(R.id.empty_list_view_headline)                                                        
 135     public TextView emptyContentHeadline;
 136 
 137     @BindView(R.id.empty_list_icon)

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactListFragment.java:137: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

 134     @BindView(R.id.empty_list_view_headline)
 135     public TextView emptyContentHeadline;
 136 
 137     @BindView(R.id.empty_list_icon)                                                                 
 138     public ImageView emptyContentIcon;
 139 
 140     @BindView(R.id.empty_list_progress)

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactListFragment.java:140: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

 137     @BindView(R.id.empty_list_icon)
 138     public ImageView emptyContentIcon;
 139 
 140     @BindView(R.id.empty_list_progress)                                                             
 141     public ProgressBar emptyContentProgressBar;
 142 
 143     @BindView(R.id.empty_list_container)

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactListFragment.java:143: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

 140     @BindView(R.id.empty_list_progress)
 141     public ProgressBar emptyContentProgressBar;
 142 
 143     @BindView(R.id.empty_list_container)                                                            
 144     public RelativeLayout emptyListContainer;
 145

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactListFragment.java:302: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

 299                 contactsPreferenceActivity.onBackPressed();
 300                 retval = true;
 301                 break;
 302             case R.id.action_select_all:                                                            
 303                 item.setChecked(!item.isChecked());
 304                 setSelectAllMenuItem(item, item.isChecked());
 305                 contactListAdapter.selectAllFiles(item.isChecked());

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactsBackupFragment.java:86: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  83     private static final String KEY_CALENDAR_MONTH = "CALENDAR_MONTH";
  84     private static final String KEY_CALENDAR_YEAR = "CALENDAR_YEAR";
  85 
  86     @BindView(R.id.contacts_automatic_backup)                                                       
  87     public SwitchCompat backupSwitch;
  88 
  89     @BindView(R.id.contacts_datepicker)

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactsBackupFragment.java:89: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  86     @BindView(R.id.contacts_automatic_backup)
  87     public SwitchCompat backupSwitch;
  88 
  89     @BindView(R.id.contacts_datepicker)                                                             
  90     public MaterialButton contactsDatePickerBtn;
  91 
  92     @BindView(R.id.contacts_last_backup_timestamp)

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactsBackupFragment.java:92: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  89     @BindView(R.id.contacts_datepicker)
  90     public MaterialButton contactsDatePickerBtn;
  91 
  92     @BindView(R.id.contacts_last_backup_timestamp)                                                  
  93     public TextView lastBackup;
  94 
  95     @BindView(R.id.contacts_backup_now)

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactsBackupFragment.java:95: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  92     @BindView(R.id.contacts_last_backup_timestamp)
  93     public TextView lastBackup;
  94 
  95     @BindView(R.id.contacts_backup_now)                                                             
  96     public MaterialButton backupNow;
  97 
  98     @Inject BackgroundJobManager backgroundJobManager;

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactsBackupFragment.java:320: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

 317         }
 318     }
 319 
 320     @OnClick(R.id.contacts_backup_now)                                                              
 321     public void backupContacts() {
 322         if (checkAndAskForContactsReadPermission()) {
 323             startContactsBackupJob();

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactsBackupFragment.java:393: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

 390         }
 391     }
 392 
 393     @OnClick(R.id.contacts_datepicker)                                                              
 394     public void openCleanDate() {
 395         openDate(null);
 396     }

../../../src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java:331: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

  328   setDrawerMenuItemChecked(menuItem.getItemId());
  329 
  330   switch (menuItem.getItemId()) {
  331       case R.id.nav_all_files:                                                                
  332           showFiles(false);
  333           if ((this instanceof FileDisplayActivity) &&
  334               !(((FileDisplayActivity) this).getListOfFilesFragment() instanceof PhotoFragment)) {

../../../src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java:345: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

  342           startActivity(intent);
  343       }
  344       break;
  345   case R.id.nav_favorites:                                                                
  346       handleSearchEvents(new SearchEvent("", SearchRemoteOperation.SearchType.FAVORITE_SEARCH),
  347                          menuItem.getItemId());
  348       break;

../../../src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java:349: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

  346       handleSearchEvents(new SearchEvent("", SearchRemoteOperation.SearchType.FAVORITE_SEARCH),
  347                          menuItem.getItemId());
  348       break;
  349   case R.id.nav_photos:                                                                   
  350       startPhotoSearch(menuItem);
  351       break;
  352   case R.id.nav_on_device:

../../../src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java:352: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

  349             case R.id.nav_photos:
  350                 startPhotoSearch(menuItem);
  351                 break;
  352             case R.id.nav_on_device:                                                                
  353                 EventBus.getDefault().post(new ChangeMenuEvent());
  354                 showFiles(true);
  355                 break;

../../../src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java:356: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

  353               EventBus.getDefault().post(new ChangeMenuEvent());
  354               showFiles(true);
  355               break;
  356           case R.id.nav_uploads:                                                                  
  357               startActivity(UploadListActivity.class, Intent.FLAG_ACTIVITY_CLEAR_TOP);
  358               break;
  359           case R.id.nav_trashbin:

../../../src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java:359: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

  356           case R.id.nav_uploads:
  357               startActivity(UploadListActivity.class, Intent.FLAG_ACTIVITY_CLEAR_TOP);
  358               break;
  359           case R.id.nav_trashbin:                                                                 
  360               startActivity(TrashbinActivity.class, Intent.FLAG_ACTIVITY_CLEAR_TOP);
  361               break;
  362           case R.id.nav_activity:

../../../src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java:362: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

  359           case R.id.nav_trashbin:
  360               startActivity(TrashbinActivity.class, Intent.FLAG_ACTIVITY_CLEAR_TOP);
  361               break;
  362           case R.id.nav_activity:                                                                 
  363               startActivity(ActivitiesActivity.class, Intent.FLAG_ACTIVITY_CLEAR_TOP);
  364               break;
  365           case R.id.nav_notifications:

../../../src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java:365: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

  362           case R.id.nav_activity:
  363               startActivity(ActivitiesActivity.class, Intent.FLAG_ACTIVITY_CLEAR_TOP);
  364               break;
  365           case R.id.nav_notifications:                                                            
  366               startActivity(NotificationsActivity.class);
  367               break;
  368           case R.id.nav_synced_folders:

../../../src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java:368: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

  365             case R.id.nav_notifications:
  366                 startActivity(NotificationsActivity.class);
  367                 break;
  368             case R.id.nav_synced_folders:                                                           
  369                 startActivity(SyncedFoldersActivity.class);
  370                 break;
  371             case R.id.nav_contacts:

../../../src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java:371: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

  368             case R.id.nav_synced_folders:
  369                 startActivity(SyncedFoldersActivity.class);
  370                 break;
  371             case R.id.nav_contacts:                                                                 
  372                 ContactsPreferenceActivity.startActivity(this);
  373                 break;
  374             case R.id.nav_settings:

../../../src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java:374: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

  371             case R.id.nav_contacts:
  372                 ContactsPreferenceActivity.startActivity(this);
  373                 break;
  374             case R.id.nav_settings:                                                                 
  375                 startActivity(SettingsActivity.class);
  376                 break;
  377             case R.id.nav_community:

../../../src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java:377: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

  374             case R.id.nav_settings:
  375                 startActivity(SettingsActivity.class);
  376                 break;
  377             case R.id.nav_community:                                                                
  378                 startActivity(CommunityActivity.class);
  379                 break;
  380             case R.id.nav_logout:

../../../src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java:380: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

  377             case R.id.nav_community:
  378                 startActivity(CommunityActivity.class);
  379                 break;
  380             case R.id.nav_logout:                                                                   
  381                 mCheckedMenuItem = -1;
  382                 menuItem.setChecked(false);
  383                 final Optional<User> optionalUser = getUser();

../../../src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java:388: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

  385           UserInfoActivity.openAccountRemovalConfirmationDialog(optionalUser.get(), getSupportFragmentManager());
  386       }
  387       break;
  388   case R.id.nav_shared:                                                                   
  389       handleSearchEvents(new SearchEvent("", SearchRemoteOperation.SearchType.SHARED_FILTER),
  390                          menuItem.getItemId());
  391       break;

../../../src/main/java/com/owncloud/android/ui/activity/DrawerActivity.java:392: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

  389       handleSearchEvents(new SearchEvent("", SearchRemoteOperation.SearchType.SHARED_FILTER),
  390                          menuItem.getItemId());
  391       break;
  392   case R.id.nav_recently_modified:                                                        
  393       handleSearchEvents(new SearchEvent("", SearchRemoteOperation.SearchType.RECENTLY_MODIFIED_SEARCH),
  394                          menuItem.getItemId());
  395       break;

../../../src/main/java/com/owncloud/android/ui/activity/EditorWebView.java:60: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  57 
  58     protected String fileName;
  59 
  60     @BindView(R.id.progressBar2)                                                                    
  61     ProgressBar progressBar;
  62 
  63     @BindView(R.id.thumbnail)

../../../src/main/java/com/owncloud/android/ui/activity/EditorWebView.java:63: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  60     @BindView(R.id.progressBar2)
  61     ProgressBar progressBar;
  62 
  63     @BindView(R.id.thumbnail)                                                                       
  64     ImageView thumbnailView;
  65 
  66     @BindView(R.id.filename)

../../../src/main/java/com/owncloud/android/ui/activity/EditorWebView.java:66: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them as annotation attributes

  63     @BindView(R.id.thumbnail)
  64     ImageView thumbnailView;
  65 
  66     @BindView(R.id.filename)                                                                        
  67     TextView fileNameTextView;
  68 
  69     private Unbinder unbinder;

../../../src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java:370: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

 367 
 368     private boolean optionsItemSelected(MenuItem item) {
 369         switch (item.getItemId()) {
 370             case R.id.action_send_file: {                                                           
 371                 containerActivity.getFileOperationsHelper().sendShareFile(getFile(), true);
 372                 return true;
 373             }

../../../src/main/java/com/owncloud/android/ui/fragment/FileDetailFragment.java:374: Resource IDs will be non-final in Android Gradle Plugin version 5.0, avoid using them in switch case statements

 371            containerActivity.getFileOperationsHelper().sendShareFile(getFile(), true);
 372            return true;
 373        }
 374        case R.id.action_open_file_with: {                                                      
 375            containerActivity.getFileOperationsHelper().openFile(getFile());
 376            return true;
 377        }

NOTE: 182 results omitted.

NonConstantResourceId Correctness Warning Priority 5/10

Using STRING instead of TEXT

../../../src/main/java/com/owncloud/android/providers/FileContentProvider.java:880: Using column type STRING; did you mean to use TEXT? (STRING is a numeric type and its value can be adjusted; for example, strings that look like integers can drop leading zeroes. See issue explanation for details.)

  877   }
  878 
  879   private void createFileSystemTable(SQLiteDatabase db) {
  880       db.execSQL("CREATE TABLE IF NOT EXISTS " + ProviderTableMeta.FILESYSTEM_TABLE_NAME + "("    
  881                      + ProviderTableMeta._ID + " INTEGER PRIMARY KEY, "      // id
  882                      + ProviderTableMeta.FILESYSTEM_FILE_LOCAL_PATH + " TEXT, "
  883                      + ProviderTableMeta.FILESYSTEM_FILE_IS_FOLDER + " INTEGER, "

In SQLite, any column can store any data type; the declared type for a column is more of a hint as to what the data should be cast to when stored.

There are many ways to store a string. TEXT, VARCHAR, CHARACTER and CLOB are string types, but `STRING` is not. Columns defined as STRING are actually numeric.

If you try to store a value in a numeric column, SQLite will try to cast it to a float or an integer before storing. If it can't, it will just store it as a string.

This can lead to some subtle bugs. For example, when SQLite encounters a string like 1234567e1234, it will parse it as a float, but the result will be out of range for floating point numbers, so Inf will be stored! Similarly, strings that look like integers will lose leading zeroes.

To fix this, you can change your schema to use a TEXT type instead.

More info: https://www.sqlite.org/datatype3.html

To suppress this error, use the issue id "SQLiteString" as explained in the Suppressing Warnings and Errors section.

SQLiteString Correctness Warning Priority 5/10

Replace usage of Switch widget

../../../src/main/java/com/owncloud/android/ui/ThemeableSwitchPreference.java:74: Use SwitchCompat from AppCompat or SwitchMaterial from Material library

  71             View child = viewGroup.getChildAt(i);
  72 
  73             if (child instanceof Switch) {
  74                 Switch switchView = (Switch) child;                                                 
  75 
  76                 if(thumbColorStateList == null && trackColorStateList == null) {
  77                     int thumbColor = ThemeUtils.primaryAccentColor(getContext());

Use SwitchCompat from AppCompat or SwitchMaterial from Material library
To suppress this error, use the issue id "UseSwitchCompatOrMaterialCode" as explained in the Suppressing Warnings and Errors section.

UseSwitchCompatOrMaterialCode Correctness Warning Priority 5/10

Vector Image Generation

../../../src/main/res/drawable/ic_circles.xml:1: This attribute is not supported in images generated from this vector icon for API < 21; check generated icon to make sure it looks acceptable

  1 <vector android:autoMirrored="true"                                                                 
  2     android:height="64dp"
  3     android:viewportHeight="57"
  4     android:viewportWidth="57"

../../../src/main/res/drawable/ic_edit.xml:23: This attribute is not supported in images generated from this vector icon for API < 21; check generated icon to make sure it looks acceptable

 20   ~ along with this program. If not, see <https://www.gnu.org/licenses/>.
 21   -->
 22 
 23 <vector android:autoMirrored="true"                                                                 
 24     android:height="24dp"
 25     android:viewportHeight="24"
 26     android:viewportWidth="24"

../../../src/main/res/drawable/ic_post_add.xml:23: This attribute is not supported in images generated from this vector icon for API < 21; check generated icon to make sure it looks acceptable

 20   ~ along with this program. If not, see <https://www.gnu.org/licenses/>.
 21   -->
 22 
 23 <vector android:autoMirrored="true"                                                                 
 24     android:height="24dp"
 25     android:viewportHeight="24"
 26     android:viewportWidth="24"

Vector icons require API 21 or API 24 depending on used features, but when minSdkVersion is less than 21 or 24 and Android Gradle plugin 1.4 or higher is used, a vector drawable placed in the drawable folder is automatically moved to drawable-anydpi-v21 or drawable-anydpi-v24 and bitmap images are generated for different screen resolutions for backwards compatibility.

However, there are some limitations to this raster image generation, and this lint check flags elements and attributes that are not fully supported. You should manually check whether the generated output is acceptable for those older devices.
To suppress this error, use the issue id "VectorRaster" as explained in the Suppressing Warnings and Errors section.

VectorRaster Correctness Warning Priority 5/10

Incompatible setRequestedOrientation value

../../../src/main/java/com/owncloud/android/authentication/AuthenticatorActivity.java:310: You should not lock orientation of your activities, so that you can support a good user experience for any device or orientation

  307 
  308         /// load user interface
  309         if (webViewLoginMethod) {
  310             setRequestedOrientation(ActivityInfo.SCREEN_ORIENTATION_PORTRAIT);                      
  311             setContentView(R.layout.account_setup_webview);
  312             mLoginWebView = findViewById(R.id.login_webview);
  313             initWebViewLogin(webloginUrl, false);

The Activity should not be locked to a portrait orientation so that users
can take advantage of the multi-window environments and larger landscape-first screens
that Android runs on such as Chrome OS. To fix the issue, consider calling
setRequestedOrientation with the ActivityInfo.SCREEN_ORIENTATION_FULL_SENSOR or
ActivityInfo.SCREEN_ORIENTATION_UNSPECIFIED options or removing the call
all together.
To suppress this error, use the issue id "SourceLockedOrientationActivity" as explained in the Suppressing Warnings and Errors section.

SourceLockedOrientationActivity Correctness Warning Priority 4/10

Allowing User Certificates

../../../src/main/res/xml/network_security_config.xml:9: The Network Security Configuration allows the use of user certificates in the release version of your app

  6             <!-- Trust preinstalled CAs -->
  7             <certificates src="system"/>
  8             <!-- Additionally trust user added CAs -->
  9             <certificates src="user"/>                                                              
 10         </trust-anchors>
 11     </base-config>
 12 </network-security-config>

Allowing user certificates could allow eavesdroppers to intercept data sent by your app, 'which could impact the privacy of your users. Consider nesting your app's trust-anchors inside a <debug-overrides> element to make sure they are only available when android:debuggable is set to "true".

More info: https://developer.android.com/training/articles/security-config#TrustingDebugCa

To suppress this error, use the issue id "AcceptsUserCertificates" as explained in the Suppressing Warnings and Errors section.

AcceptsUserCertificates Security Warning Priority 5/10

Exported service does not require permission

../../../src/gplay/AndroidManifest.xml:65: Exported service does not require permission

 62             tools:replace="android:targetActivity"/>
 63 
 64 
 65         <service                                                                                    
 66             android:name=".services.firebase.NCFirebaseMessagingService">
 67             <intent-filter>
 68                 <action android:name="com.google.firebase.MESSAGING_EVENT"/>

Applies to variants: gplayDebug, gplayRelease
Does not apply to variants: genericDebug, genericRelease, qaDebug, qaRelease, versionDevDebug, versionDevRelease
../../../src/main/AndroidManifest.xml:180: Exported service does not require permission

 177             android:label="@string/app_name"
 178             android:theme="@style/Theme.ownCloud.Fullscreen" />
 179 
 180         <service                                                                                    
 181             android:name=".authentication.AccountAuthenticatorService"
 182             android:exported="true" >
 183             <intent-filter android:priority="100" >

../../../src/main/AndroidManifest.xml:192: Exported service does not require permission

 189                 android:resource="@xml/authenticator" />
 190         </service>
 191 
 192         <service                                                                                    
 193             android:name=".syncadapter.FileSyncService"
 194             android:exported="true" >
 195             <intent-filter>

../../../src/main/AndroidManifest.xml:398: Exported service does not require permission

 395                   android:theme="@style/Theme.ownCloud" />
 396 
 397 
 398         <service                                                                                    
 399             android:name=".services.AccountManagerService"
 400             android:enabled="true"
 401             android:exported="true" >

Exported services (services which either set exported=true or contain an intent-filter and do not specify exported=false) should define a permission that an entity must have in order to launch the service or bind to it. Without this, any application can use this service.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "ExportedService" as explained in the Suppressing Warnings and Errors section.

ExportedService Security Warning Priority 5/10

Insecure Base Configuration

../../../src/main/res/xml/network_security_config.xml:4: Insecure Base Configuration

  1 <?xml version="1.0" encoding="utf-8"?>
  2 
  3 <network-security-config>
  4     <base-config cleartextTrafficPermitted="true">                                                  
  5         <trust-anchors>
  6             <!-- Trust preinstalled CAs -->
  7             <certificates src="system"/>

Permitting cleartext traffic could allow eavesdroppers to intercept data sent by your app, which impacts the privacy of your users. Consider only allowing encrypted traffic by setting the cleartextTrafficPermitted tag to "false".

More info: https://developer.android.com/preview/features/security-config.html

To suppress this error, use the issue id "InsecureBaseConfiguration" as explained in the Suppressing Warnings and Errors section.

InsecureBaseConfiguration Security Warning Priority 5/10

Static Field Leaks

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactListFragment.java:527: This AsyncTask class should be static or leaks might occur (anonymous android.os.AsyncTask)

 524 
 525   }
 526 
 527   private AsyncTask<Void, Void, Boolean> loadContactsTask = new AsyncTask<Void, Void, Boolean>() {
 528 
 529       @Override
 530       protected void onPreExecute() {

../../../src/main/java/com/owncloud/android/ui/fragment/contactsbackup/ContactsBackupFragment.java:218: This AsyncTask class should be static or leaks might occur (anonymous android.os.AsyncTask)

 215 
 216   private void refreshBackupFolder(final String backupFolderPath,
 217                                    final ContactsPreferenceActivity contactsPreferenceActivity) {
 218       AsyncTask<String, Integer, Boolean> task = new AsyncTask<String, Integer, Boolean>() {      
 219           @Override
 220           protected Boolean doInBackground(String... path) {
 221               FileDataStorageManager storageManager = new FileDataStorageManager(account,

../../../src/main/java/com/owncloud/android/ui/asynctasks/CopyAndUploadContentUrisTask.java:58: This field leaks a context object

  55    */
  56   private WeakReference<OnCopyTmpFilesTaskListener> mListener;
  57 
  58   /**                                                                                             
  59    * Reference to application context, used to access app resources. Holding it should not be a problem,
  60    * since it needs to exist until the end of the AsyncTask although the caller Activity were finished
  61    * before.

../../../src/main/java/com/owncloud/android/ui/activity/ErrorsWhileCopyingHandlerActivity.java:209: This AsyncTask class should be static or leaks might occur (com.owncloud.android.ui.activity.ErrorsWhileCopyingHandlerActivity.MoveFilesTask)

 206     /**
 207      * Asynchronous task performing the move of all the local files to the ownCloud folder.
 208      */
 209     private class MoveFilesTask extends AsyncTask<Void, Void, Boolean> {                            
 210 
 211         /**
 212          * Updates the UI before trying the movement

../../../src/main/java/com/owncloud/android/ui/asynctasks/FetchRemoteFileTask.java:49: This field leaks a context object

  46     private Account account;
  47     private String fileId;
  48     private FileDataStorageManager storageManager;
  49     private FileDisplayActivity fileDisplayActivity;                                                
  50 
  51     public FetchRemoteFileTask(Account account,
  52                                String fileId,

../../../src/main/java/com/owncloud/android/ui/activities/data/files/FilesServiceApiImpl.java:75: This field leaks a context object

  72         private final FilesServiceCallback<OCFile> callback;
  73         private OCFile remoteOcFile;
  74         private String errorMessage;
  75         // TODO: Figure out a better way to do this than passing a BaseActivity reference.          
  76         private final BaseActivity baseActivity;
  77         private final String fileUrl;
  78         private final User user;

../../../src/main/java/com/nextcloud/client/logger/ui/LogsViewModel.kt:34: This field leaks a context object

  31 import javax.inject.Inject
  32 
  33 class LogsViewModel @Inject constructor(
  34     private val context: Context,                                                                   
  35     clock: Clock,
  36     asyncRunner: AsyncRunner,
  37     private val logsRepository: LogsRepository

../../../src/main/java/com/owncloud/android/MainApp.java:129: Do not place Android context classes in static fields; this is a memory leak

 126     private static final String TAG = MainApp.class.getSimpleName();
 127     public static final String DOT = ".";
 128 
 129     private static Context mContext;                                                                
 130 
 131     private static String storagePath;

../../../src/main/java/com/owncloud/android/ui/activity/ManageSpaceActivity.java:92: This AsyncTask class should be static or leaks might occur (com.owncloud.android.ui.activity.ManageSpaceActivity.ClearDataAsyncTask)

  89     /**
  90      * AsyncTask for Clear Data, saving the passcode
  91      */
  92     private class ClearDataAsyncTask extends AsyncTask<Void, Void, Boolean>{                        
  93 
  94         private final AppPreferences preferences = ManageSpaceActivity.this.preferences;

../../../src/main/java/com/owncloud/android/ui/asynctasks/NotificationExecuteActionTask.java:27: This field leaks a context object

 24    private NotificationListAdapter.NotificationViewHolder holder;
 25    private OwnCloudClient client;
 26    private Notification notification;
 27    private NotificationsActivity notificationsActivity;                                            
 28 
 29    public NotificationExecuteActionTask(OwnCloudClient client,
 30                                         NotificationListAdapter.NotificationViewHolder holder,

../../../src/main/java/com/owncloud/android/ui/fragment/OCFileListFragment.java:1565: This AsyncTask class should be static or leaks might occur (anonymous android.os.AsyncTask)

 1562             remoteOperation = new GetSharesRemoteOperation();
 1563         }
 1564 
 1565         remoteOperationAsyncTask = new AsyncTask<Void, Void, Boolean>() {                           
 1566             @Override
 1567             protected Boolean doInBackground(Void... voids) {
 1568                 setTitle();

../../../src/main/java/com/owncloud/android/ui/preview/PreviewImageFragment.java:478: This AsyncTask class should be static or leaks might occur (com.owncloud.android.ui.preview.PreviewImageFragment.LoadBitmapTask)

 475     }
 476 
 477 
 478     private class LoadBitmapTask extends AsyncTask<OCFile, Void, LoadImage> {                       
 479         private static final int PARAMS_LENGTH = 1;
 480 
 481         /**

../../../src/main/java/com/owncloud/android/ui/preview/PreviewTextFileFragment.java:150: This AsyncTask class should be static or leaks might occur (com.owncloud.android.ui.preview.PreviewTextFileFragment.TextLoadAsyncTask)

 147     /**
 148      * Reads the file to preview and shows its contents. Too critical to be anonymous.
 149      */
 150     private class TextLoadAsyncTask extends AsyncTask<Object, Void, StringWriter> {                 
 151         private static final int PARAMS_LENGTH = 1;
 152         private final WeakReference<TextView> mTextViewReference;

../../../src/main/java/com/owncloud/android/ui/dialog/SetupEncryptionDialogFragment.java:238: This AsyncTask class should be static or leaks might occur (com.owncloud.android.ui.dialog.SetupEncryptionDialogFragment.DownloadKeysAsyncTask)

 235         return dialog;
 236     }
 237 
 238     public class DownloadKeysAsyncTask extends AsyncTask<Void, Void, String> {                      
 239         @Override
 240         protected void onPreExecute() {
 241             super.onPreExecute();

../../../src/main/java/com/owncloud/android/ui/dialog/SetupEncryptionDialogFragment.java:303: This AsyncTask class should be static or leaks might occur (com.owncloud.android.ui.dialog.SetupEncryptionDialogFragment.GenerateNewKeysAsyncTask)

 300         }
 301     }
 302 
 303     public class GenerateNewKeysAsyncTask extends AsyncTask<Void, Void, String> {                   
 304         @Override
 305         protected void onPreExecute() {
 306             super.onPreExecute();

../../../src/main/java/com/owncloud/android/ui/activity/StorageMigration.java:169: This field leaks a context object

 166   private static abstract class FileMigrationTaskBase extends AsyncTask<Void, Integer, Integer> {
 167       protected String mStorageSource;
 168       protected String mStorageTarget;
 169       protected Context mContext;                                                                 
 170       protected ProgressDialog mProgressDialog;
 171       protected StorageMigrationProgressListener mListener;

../../../src/main/java/com/owncloud/android/datamodel/ThumbnailsCacheManager.java:728: This field leaks a context object

  725         private final WeakReference<ImageView> mImageViewReference;
  726         private File mFile;
  727         private String mImageKey;
  728         private Context mContext;                                                                   
  729 
  730         public MediaThumbnailGenerationTask(ImageView imageView, Context context) {
  731             // Use a WeakReference to ensure the ImageView can be garbage collected

../../../src/main/java/com/owncloud/android/datamodel/ThumbnailsCacheManager.java:860: This field leaks a context object

  857         private Account mAccount;
  858         private String mUserId;
  859         private String mServerName;
  860         private Context mContext;                                                                   
  861 
  862 
  863         public AvatarGenerationTask(AvatarGenerationListener avatarGenerationListener,

A static field will leak contexts.

Non-static inner classes have an implicit reference to their outer class. If that outer class is for example a Fragment or Activity, then this reference means that the long-running handler/loader/task will hold a reference to the activity which prevents it from getting garbage collected.

Similarly, direct field references to activities and fragments from these longer running instances can cause leaks.

ViewModel classes should never point to Views or non-application Contexts.
To suppress this error, use the issue id "StaticFieldLeak" as explained in the Suppressing Warnings and Errors section.

StaticFieldLeak Performance Warning Priority 6/10

Handler reference leaks

../../../src/main/java/com/owncloud/android/media/MediaControlView.java:165: This Handler class should be static or leaks might occur (anonymous android.os.Handler)

 162     }
 163 
 164 
 165     private Handler handler = new Handler() {                                                       
 166         @Override
 167         public void handleMessage(Message msg) {
 168             int pos;

Since this Handler is declared as an inner class, it may prevent the outer class from being garbage collected. If the Handler is using a Looper or MessageQueue for a thread other than the main thread, then there is no issue. If the Handler is using the Looper or MessageQueue of the main thread, you need to fix your Handler declaration, as follows: Declare the Handler as a static class; In the outer class, instantiate a WeakReference to the outer class and pass this object to your Handler when you instantiate the Handler; Make all references to members of the outer class using the WeakReference object.
To suppress this error, use the issue id "HandlerLeak" as explained in the Suppressing Warnings and Errors section.

HandlerLeak Performance Warning Priority 4/10

FrameLayout can be replaced with <merge> tag

../../../src/main/res/layout/account_setup_webview.xml:2: This <FrameLayout> can be replaced with a <merge> tag

  1 <?xml version="1.0" encoding="utf-8"?>
  2 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"                             
  3              android:orientation="vertical"
  4              android:layout_width="match_parent"
  5              android:layout_height="match_parent">

../../../src/main/res/layout/video_layout.xml:19: This <FrameLayout> can be replaced with a <merge> tag

 16   You should have received a copy of the GNU General Public License
 17   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 18 -->
 19 <FrameLayout    xmlns:android="http://schemas.android.com/apk/res/android"                             
 20                 android:layout_width="match_parent"
 21                 android:layout_height="match_parent" >

If a <FrameLayout> is the root of a layout and does not provide background or padding etc, it can often be replaced with a <merge> tag which is slightly more efficient. Note that this depends on context, so make sure you understand how the <merge> tag works before proceeding.

More info: https://android-developers.googleblog.com/2009/03/android-layout-tricks-3-optimize-by.html

To suppress this error, use the issue id "MergeRootFrame" as explained in the Suppressing Warnings and Errors section.

MergeRootFrame Performance Warning Priority 4/10

Nested layout weights

../../../src/main/res/layout/first_run_activity.xml:40: Nested weights are bad for performance

  37             android:id="@+id/contentPanel"
  38             android:layout_width="match_parent"
  39             android:layout_height="0dp"
  40             android:layout_weight="1"/>                                                             
  41 
  42         <com.owncloud.android.ui.whatsnew.ProgressIndicator
  43             android:id="@+id/progressIndicator"

../../../src/main/res/layout/whats_new_activity.xml:63: Nested weights are bad for performance

 60             android:layout_width="0dp"
 61             android:layout_height="match_parent"
 62             android:layout_gravity="center_vertical|center_horizontal"
 63             android:layout_weight="1"                                                               
 64             android:gravity="center"
 65             android:paddingLeft="0dp"
 66             android:paddingRight="0dp"

Layout weights require a widget to be measured twice. When a LinearLayout with non-zero weights is nested inside another LinearLayout with non-zero weights, then the number of measurements increase exponentially.
To suppress this error, use the issue id "NestedWeights" as explained in the Suppressing Warnings and Errors section.

NestedWeights Performance Warning Priority 3/10

Overdraw: Painting regions more than once

../../../src/main/res/layout/activity_row.xml:23: Possible overdraw: Root element paints background ?android:attr/activatedBackgroundIndicator with a theme that also paints a background (inferred theme is @style/Theme.ownCloud.Toolbar)

 20     android:id="@+id/list_item"
 21     android:layout_width="match_parent"
 22     android:layout_height="@dimen/activity_row_layout_height"
 23     android:background="?android:attr/activatedBackgroundIndicator"                                    
 24     android:minWidth="@dimen/activity_row_layout_min_width_independent"
 25     android:orientation="horizontal"
 26     android:paddingEnd="@dimen/standard_padding"

../../../src/main/res/layout/generic_explanation.xml:22: Possible overdraw: Root element paints background @color/bg_default with a theme that also paints a background (inferred theme is @style/Theme.ownCloud.Toolbar)

 19 <LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
 20     android:layout_width="match_parent"
 21     android:layout_height="match_parent"
 22     android:background="@color/bg_default"                                                          
 23     android:id="@+id/explanation"
 24     android:orientation="vertical">

../../../src/main/res/layout/info_box.xml:27: Possible overdraw: Root element paints background @color/filelist_icon_background with a theme that also paints a background (inferred theme is @style/Theme.ownCloud.Toolbar)

 24     android:layout_width="match_parent"
 25     android:layout_height="wrap_content"
 26     android:layout_gravity="center_horizontal|bottom"
 27     android:background="@color/filelist_icon_background"                                            
 28     android:gravity="center"
 29     android:padding="@dimen/standard_half_padding"
 30     android:visibility="gone">

../../../src/main/res/layout/toolbar_standard.xml:27: Possible overdraw: Root element paints background @color/bg_default with a theme that also paints a background (inferred theme is @style/Theme.ownCloud.Toolbar)

  24     android:id="@+id/appbar"
  25     android:layout_width="match_parent"
  26     android:layout_height="wrap_content"
  27     android:background="@color/bg_default"                                                          
  28     tools:viewBindingIgnore="true">
  29 
  30     <FrameLayout

../../../src/main/res/layout/user_info_layout.xml:25: Possible overdraw: Root element paints background @color/bg_default with a theme that also paints a background (inferred theme is @style/Theme.ownCloud.Toolbar)

  22     xmlns:tools="http://schemas.android.com/tools"
  23     android:layout_width="match_parent"
  24     android:layout_height="match_parent"
  25     android:background="@color/bg_default"                                                          
  26     android:orientation="vertical">
  27 
  28     <include layout="@layout/toolbar_standard" />

Overdraw Performance Warning Priority 3/10

Using getUsableSpace()

../../../src/main/java/com/owncloud/android/utils/FileStorageUtils.java:140: Consider also using StorageManager#getAllocatableBytes and allocateBytes which will consider clearable cached data

 137      */
 138     public static long getUsableSpace() {
 139         File savePath = new File(MainApp.getStoragePath());
 140         return savePath.getUsableSpace();                                                           
 141     }
 142 
 143     /**

When you need to allocate disk space for large files, consider using the new allocateBytes(FileDescriptor, long) API, which will automatically clear cached files belonging to other apps (as needed) to meet your request.

When deciding if the device has enough disk space to hold your new data, call getAllocatableBytes(UUID) instead of using getUsableSpace(), since the former will consider any cached data that the system is willing to clear on your behalf.

Note that these methods require API level 26. If your app is running on older devices, you will probably need to use both APIs, conditionally switching on Build.VERSION.SDK_INT. Lint only looks in the same compilation unit to see if you are already using both APIs, so if it warns even though you are already using the new API, consider moving the calls to the same file or suppressing the warning.
To suppress this error, use the issue id "UsableSpace" as explained in the Suppressing Warnings and Errors section.

UsableSpace Performance Warning Priority 3/10

Accessibility in Custom Views

../../../src/main/java/com/owncloud/android/ui/fragment/ExtendedListFragment.java:374: Custom view `RecyclerView` has setOnTouchListener called on it but does not override performClick

 371 
 372   mScaleGestureDetector = new ScaleGestureDetector(MainApp.getAppContext(), new ScaleListener());
 373 
 374   getRecyclerView().setOnTouchListener((view, motionEvent) -> {                               
 375       mScaleGestureDetector.onTouchEvent(motionEvent);
 376 
 377       if (motionEvent.getAction() == MotionEvent.ACTION_UP) {

../../../src/main/java/com/owncloud/android/ui/preview/PreviewMediaFragment.java:196: Custom view `VideoView` has setOnTouchListener called on it but does not override performClick

 193         mPreviewContainer = view.findViewById(R.id.file_preview_container);
 194         mImagePreview = view.findViewById(R.id.image_preview);
 195         mVideoPreview = view.findViewById(R.id.video_preview);
 196         mVideoPreview.setOnTouchListener(this);                                                     
 197 
 198         mMediaController = view.findViewById(R.id.media_controller);

../../../src/main/java/com/owncloud/android/ui/preview/PreviewMediaFragment.java:622: PreviewMediaFragment#onTouch should call View#performClick when a click is detected

 619   }
 620 
 621   @Override
 622   public boolean onTouch(View v, MotionEvent event) {                                             
 623       if (event.getAction() == MotionEvent.ACTION_DOWN && v.equals(mVideoPreview)) {
 624           // added a margin on the left to avoid interfering with gesture to open navigation drawer
 625           if (event.getX() / Resources.getSystem().getDisplayMetrics().density > MIN_DENSITY_RATIO) {

If a View that overrides onTouchEvent or uses an OnTouchListener does not also implement performClick and call it when clicks are detected, the View may not handle accessibility actions properly. Logic handling the click actions should ideally be placed in View#performClick as some accessibility services invoke performClick when a click action should occur.
To suppress this error, use the issue id "ClickableViewAccessibility" as explained in the Suppressing Warnings and Errors section.

ClickableViewAccessibility Accessibility Warning Priority 6/10

Keyboard inaccessible widget

../../../src/main/res/layout/activity_list_layout.xml:25: 'clickable' attribute found, please also add 'focusable'

 22     android:id="@+id/drawer_layout"
 23     android:layout_width="match_parent"
 24     android:layout_height="match_parent"
 25     android:clickable="true"                                                                        
 26     android:fitsSystemWindows="true">
 27 
 28     <androidx.coordinatorlayout.widget.CoordinatorLayout

../../../src/main/res/layout/community_layout.xml:26: 'clickable' attribute found, please also add 'focusable'

  23     xmlns:app="http://schemas.android.com/apk/res-auto"
  24     android:layout_width="match_parent"
  25     android:layout_height="match_parent"
  26     android:clickable="true"                                                                        
  27     android:fitsSystemWindows="true">
  28 
  29     <!-- The main content view -->

../../../src/main/res/layout/contacts_preference.xml:25: 'clickable' attribute found, please also add 'focusable'

 22     android:id="@+id/drawer_layout"
 23     android:layout_width="match_parent"
 24     android:layout_height="match_parent"
 25     android:clickable="true"                                                                        
 26     android:fitsSystemWindows="true">
 27 
 28     <!-- The main content view -->

../../../src/main/res/layout/files.xml:24: 'clickable' attribute found, please also add 'focusable'

 21     android:id="@+id/drawer_layout"
 22     android:layout_width="match_parent"
 23     android:layout_height="match_parent"
 24     android:clickable="true"
                                                                       
 25     android:fitsSystemWindows="true">
 26 
 27     <androidx.coordinatorlayout.widget.CoordinatorLayout

../../../src/main/res/layout/notifications_layout.xml:27: 'clickable' attribute found, please also add 'focusable'

 24     android:id="@+id/drawer_layout"
 25     android:layout_width="match_parent"
 26     android:layout_height="match_parent"
 27     android:clickable="true"                                                                        
 28     android:fitsSystemWindows="true">
 29 
 30     <androidx.coordinatorlayout.widget.CoordinatorLayout

../../../src/main/res/layout/preview_image_activity.xml:24: 'clickable' attribute found, please also add 'focusable'

 21     android:id="@+id/drawer_layout"
 22     android:layout_width="match_parent"
 23     android:layout_height="match_parent"
 24     android:clickable="true" >                                                                      
 25 
 26     <com.owncloud.android.ui.components.CustomViewPager
 27         android:id="@+id/fragmentPager"

A widget that is declared to be clickable but not declared to be focusable is not accessible via the keyboard. Please add the focusable attribute as well.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "KeyboardInaccessibleWidget" as explained in the Suppressing Warnings and Errors section.

KeyboardInaccessibleWidget Accessibility Warning Priority 3/10

Overlapping items in RelativeLayout

../../../src/main/res/layout/synced_folders_settings_layout.xml:382: LinearLayout-3 can overlap @id/delete if @string/common_delete, LinearLayout-3 grow due to localized text expansion

 379             android:layout_alignParentStart="true"
 380             android:text="@string/common_delete" />
 381 
 382         <LinearLayout                                                                               
 383             android:layout_width="wrap_content"
 384             android:layout_height="wrap_content"
 385             android:layout_alignParentEnd="true">

If relative layout has text or button items aligned to left and right sides they can overlap each other due to localized text expansion unless they have mutual constraints like toEndOf/toStartOf.
To suppress this error, use the issue id "RelativeOverlap" as explained in the Suppressing Warnings and Errors section.

RelativeOverlap Internationalization Warning Priority 3/10

Disabled Checks

One or more issues were not run by lint, either because the check is not enabled by default, or because it was disabled with a command line flag or via one or more lint.xml configuration files in the project directories.

AppLinksAutoVerifyError

Disabled By: Default

Ensures that app links are correctly set and associated with website.

More info: https://g.co/appindexing/applinks

To suppress this error, use the issue id "AppLinksAutoVerifyError" as explained in the Suppressing Warnings and Errors section.

AppLinksAutoVerifyWarning

Disabled By: Default

Ensures that app links are correctly set and associated with website.

More info: https://g.co/appindexing/applinks

To suppress this error, use the issue id "AppLinksAutoVerifyWarning" as explained in the Suppressing Warnings and Errors section.

BackButton

Disabled By: Default

According to the Android Design Guide,

"Other platforms use an explicit back button with label to allow the user to navigate up the application's hierarchy. Instead, Android uses the main action bar's app icon for hierarchical navigation and the navigation bar's back button for temporal navigation."
This check is not very sophisticated (it just looks for buttons with the label "Back"), so it is disabled by default to not trigger on common scenarios like pairs of Back/Next buttons to paginate through screens.

More info: https://material.io/design/

To suppress this error, use the issue id "BackButton" as explained in the Suppressing Warnings and Errors section.

ConvertToWebp

Disabled By: Default

The WebP format is typically more compact than PNG and JPEG. As of Android 4.2.1 it supports transparency and lossless conversion as well. Note that there is a quickfix in the IDE which lets you perform conversion.

Launcher icons must be in the PNG format.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "ConvertToWebp" as explained in the Suppressing Warnings and Errors section.

DalvikOverride

Disabled By: Default

The Dalvik virtual machine will treat a package private method in one class as overriding a package private method in its super class, even if they are in separate packages.

If you really did intend for this method to override the other, make the method protected instead.

If you did not intend the override, consider making the method private, or changing its name or signature.

Note that this check is disabled be default, because ART (the successor to Dalvik) no longer has this behavior.
To suppress this error, use the issue id "DalvikOverride" as explained in the Suppressing Warnings and Errors section.

DuplicateStrings

Disabled By: Default

Duplicate strings can make applications larger unnecessarily.

This lint check looks for duplicate strings, including differences for strings where the only difference is in capitalization. Title casing and all uppercase can all be adjusted in the layout or in code.

More info: https://developer.android.com/reference/android/widget/TextView.html#attr_android:inputType

To suppress this error, use the issue id "DuplicateStrings" as explained in the Suppressing Warnings and Errors section.

EasterEgg

Disabled By: Default

An "easter egg" is code deliberately hidden in the code, both from potential users and even from other developers. This lint check looks for code which looks like it may be hidden from sight.
To suppress this error, use the issue id "EasterEgg" as explained in the Suppressing Warnings and Errors section.

ExpensiveAssertion

Disabled By: Default

In Kotlin, assertions are not handled the same way as from the Java programming language. In particular, they're just implemented as a library call, and inside the library call the error is only thrown if assertions are enabled.

This means that the arguments to the assert call will always be evaluated. If you're doing any computation in the expression being asserted, that computation will unconditionally be performed whether or not assertions are turned on. This typically turns into wasted work in release builds.

This check looks for cases where the assertion condition is nontrivial, e.g. it is performing method calls or doing more work than simple comparisons on local variables or fields.

You can work around this by writing your own inline assert method instead:

@Suppress("INVISIBLE_REFERENCE", "INVISIBLE_MEMBER")
inline fun assert(condition: () -> Boolean) {
    if (_Assertions.ENABLED && !condition()) {
        throw AssertionError()
    }
}

In Android, because assertions are not enforced at runtime, instead use this:

inline fun assert(condition: () -> Boolean) {
    if (BuildConfig.DEBUG && !condition()) {
        throw AssertionError()
    }
}

To suppress this error, use the issue id "ExpensiveAssertion" as explained in the Suppressing Warnings and Errors section.

FieldGetter

Disabled By: Default

Accessing a field within the class that defines a getter for that field is at least 3 times faster than calling the getter. For simple getters that do nothing other than return the field, you might want to just reference the local field directly instead.

NOTE: As of Android 2.3 (Gingerbread), this optimization is performed automatically by Dalvik, so there is no need to change your code; this is only relevant if you are targeting older versions of Android.

More info: https://developer.android.com/training/articles/perf-tips#internal_get_set

To suppress this error, use the issue id "FieldGetter" as explained in the Suppressing Warnings and Errors section.

GoogleAppIndexingApiWarning

Disabled By: Default

Adds URLs to get your app into the Google index, to get installs and traffic to your app from Google Search.

More info: https://g.co/AppIndexing/AndroidStudio

Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "GoogleAppIndexingApiWarning" as explained in the Suppressing Warnings and Errors section.

GoogleAppIndexingWarning

Disabled By: Command line flag

Adds URLs to get your app into the Google index, to get installs and traffic to your app from Google Search.

More info: https://g.co/AppIndexing/AndroidStudio

Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "GoogleAppIndexingWarning" as explained in the Suppressing Warnings and Errors section.

GradleDependency

Disabled By: Command line flag

This detector looks for usages of libraries where the version you are using is not the current stable release. Using older versions is fine, and there are cases where you deliberately want to stick with an older version. However, you may simply not be aware that a more recent version is available, and that is what this lint check helps find.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "GradleDependency" as explained in the Suppressing Warnings and Errors section.

IconDensities

Disabled By: Command line flag

Icons will look best if a custom version is provided for each of the major screen density classes (low, medium, high, extra high). This lint check identifies icons which do not have complete coverage across the densities.

Low density is not really used much anymore, so this check ignores the ldpi density. To force lint to include it, set the environment variable ANDROID_LINT_INCLUDE_LDPI=true. For more information on current density usage, see https://developer.android.com/about/dashboards

More info: https://developer.android.com/guide/practices/screens_support.html

To suppress this error, use the issue id "IconDensities" as explained in the Suppressing Warnings and Errors section.

IconExpectedSize

Disabled By: Default

There are predefined sizes (for each density) for launcher icons. You should follow these conventions to make sure your icons fit in with the overall look of the platform.

More info: https://material.io/design/iconography/

To suppress this error, use the issue id "IconExpectedSize" as explained in the Suppressing Warnings and Errors section.

IconMissingDensityFolder

Disabled By: Command line flag

Icons will look best if a custom version is provided for each of the major screen density classes (low, medium, high, extra-high, extra-extra-high). This lint check identifies folders which are missing, such as drawable-hdpi.

Low density is not really used much anymore, so this check ignores the ldpi density. To force lint to include it, set the environment variable ANDROID_LINT_INCLUDE_LDPI=true. For more information on current density usage, see https://developer.android.com/about/dashboards

More info: https://developer.android.com/guide/practices/screens_support.html

To suppress this error, use the issue id "IconMissingDensityFolder" as explained in the Suppressing Warnings and Errors section.

ImplicitSamInstance

Disabled By: Default

Kotlin's support for SAM (single accessor method) interfaces lets you pass a lambda to the interface. This will create a new instance on the fly even though there is no explicit constructor call. If you pass one of these lambdas or method references into a method which (for example) stores or compares the object identity, unexpected results may happen.
To suppress this error, use the issue id "ImplicitSamInstance" as explained in the Suppressing Warnings and Errors section.

InvalidPackage

Disabled By: Default

This check scans through libraries looking for calls to APIs that are not included in Android.

When you create Android projects, the classpath is set up such that you can only access classes in the API packages that are included in Android. However, if you add other projects to your libs/ folder, there is no guarantee that those .jar files were built with an Android specific classpath, and in particular, they could be accessing unsupported APIs such as java.applet.

This check scans through library jars and looks for references to API packages that are not included in Android and flags these. This is only an error if your code calls one of the library classes which wind up referencing the unsupported package.
To suppress this error, use the issue id "InvalidPackage" as explained in the Suppressing Warnings and Errors section.

KotlinPropertyAccess

Disabled By: Default

For a method to be represented as a property in Kotlin, strict “bean”-style prefixing must be used.

Accessor methods require a ‘get’ prefix or for boolean-returning methods an ‘is’ prefix can be used.

More info: https://android.github.io/kotlin-guides/interop.html#property-prefixes

To suppress this error, use the issue id "KotlinPropertyAccess" as explained in the Suppressing Warnings and Errors section.

LambdaLast

Disabled By: Default

To improve calling this code from Kotlin,
parameter types eligible for SAM conversion should be last.

More info: https://android.github.io/kotlin-guides/interop.html#lambda-parameters-last

To suppress this error, use the issue id "LambdaLast" as explained in the Suppressing Warnings and Errors section.

LintImplPsiEquals

Disabled By: Default

You should never compare two PSI elements for equality with equals;
use isEquivalentTo(PsiElement) instead.
To suppress this error, use the issue id "LintImplPsiEquals" as explained in the Suppressing Warnings and Errors section.

LintImplUnexpectedDomain

Disabled By: Default

This checks flags URLs to domains that have not been explicitly whitelisted for use as a documentation source.
To suppress this error, use the issue id "LintImplUnexpectedDomain" as explained in the Suppressing Warnings and Errors section.

LogConditional

Disabled By: Default

The BuildConfig class provides a constant, DEBUG, which indicates whether the code is being built in release mode or in debug mode. In release mode, you typically want to strip out all the logging calls. Since the compiler will automatically remove all code which is inside a if (false) check, surrounding your logging calls with a check for BuildConfig.DEBUG is a good idea.

If you really intend for the logging to be present in release mode, you can suppress this warning with a @SuppressLint annotation for the intentional logging calls.
To suppress this error, use the issue id "LogConditional" as explained in the Suppressing Warnings and Errors section.

MangledCRLF

Disabled By: Default

On Windows, line endings are typically recorded as carriage return plus newline: \r\n.

This detector looks for invalid line endings with repeated carriage return characters (without newlines). Previous versions of the ADT plugin could accidentally introduce these into the file, and when editing the file, the editor could produce confusing visual artifacts.

More info: https://bugs.eclipse.org/bugs/show_bug.cgi?id=375421

To suppress this error, use the issue id "MangledCRLF" as explained in the Suppressing Warnings and Errors section.

MinSdkTooLow

Disabled By: Default

The value of the minSdkVersion property is too low and can be incremented without noticeably reducing the number of supported devices.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "MinSdkTooLow" as explained in the Suppressing Warnings and Errors section.

MissingDefaultResource

Disabled By: Command line flag

If a resource is only defined in folders with qualifiers like -land or -en, and there is no default declaration in the base folder (layout or values etc), then the app will crash if that resource is accessed on a device where the device is in a configuration missing the given qualifier.

As a special case, drawables do not have to be specified in the base folder; if there is a match in a density folder (such as drawable-mdpi) that image will be used and scaled. Note however that if you only specify a drawable in a folder like drawable-en-hdpi, the app will crash in non-English locales.

There may be scenarios where you have a resource, such as a -fr drawable, which is only referenced from some other resource with the same qualifiers (such as a -fr style), which itself has safe fallbacks. However, this still makes it possible for somebody to accidentally reference the drawable and crash, so it is safer to create a default dummy fallback in the base folder. Alternatively, you can suppress the issue by adding tools:ignore="MissingDefaultResource" on the element.

(This scenario frequently happens with string translations, where you might delete code and the corresponding resources, but forget to delete a translation. There is a dedicated issue id for that scenario, with the id ExtraTranslation.)
To suppress this error, use the issue id "MissingDefaultResource" as explained in the Suppressing Warnings and Errors section.

MissingTranslation

Disabled By: Command line flag

If an application has more than one locale, then all the strings declared in one language should also be translated in all other languages.

If the string should not be translated, you can add the attribute translatable="false" on the <string> element, or you can define all your non-translatable strings in a resource file called donottranslate.xml. Or, you can ignore the issue with a tools:ignore="MissingTranslation" attribute.

You can tell lint (and other tools) which language is the default language in your res/values/ folder by specifying tools:locale="languageCode" for the root <resources> element in your resource file. (The tools prefix refers to the namespace declaration http://schemas.android.com/tools.)
To suppress this error, use the issue id "MissingTranslation" as explained in the Suppressing Warnings and Errors section.

NegativeMargin

Disabled By: Default

Margin values should be positive. Negative values are generally a sign that you are making assumptions about views surrounding the current one, or may be tempted to turn off child clipping to allow a view to escape its parent. Turning off child clipping to do this not only leads to poor graphical performance, it also results in wrong touch event handling since touch events are based strictly on a chain of parent-rect hit tests. Finally, making assumptions about the size of strings can lead to localization problems.
To suppress this error, use the issue id "NegativeMargin" as explained in the Suppressing Warnings and Errors section.

NewerVersionAvailable

Disabled By: Default

This detector checks with a central repository to see if there are newer versions available for the dependencies used by this project. This is similar to the GradleDependency check, which checks for newer versions available in the Android SDK tools and libraries, but this works with any MavenCentral dependency, and connects to the library every time, which makes it more flexible but also much slower.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "NewerVersionAvailable" as explained in the Suppressing Warnings and Errors section.

NoHardKeywords

Disabled By: Default

Do not use Kotlin’s hard keywords as the name of methods or fields.
These require the use of backticks to escape when calling from Kotlin.
Soft keywords, modifier keywords, and special identifiers are allowed.

For example, Mockito’s when function requires backticks when used from Kotlin:

val callable = Mockito.mock(Callable::class.java)
Mockito.`when`(callable.call()).thenReturn(/* … */)

More info: https://android.github.io/kotlin-guides/interop.html#no-hard-keywords

To suppress this error, use the issue id "NoHardKeywords" as explained in the Suppressing Warnings and Errors section.

PermissionImpliesUnsupportedChromeOsHardware

Disabled By: Default

The <uses-permission> element should not require a permission that implies an unsupported Chrome OS hardware feature. Google Play assumes that certain hardware related permissions indicate that the underlying hardware features are required by default. To fix the issue, consider declaring the corresponding uses-feature element with required="false" attribute.

More info: https://developer.android.com/topic/arc/manifest.html#implied-features

Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "PermissionImpliesUnsupportedChromeOsHardware" as explained in the Suppressing Warnings and Errors section.

Registered

Disabled By: Default

Activities, services and content providers should be registered in the AndroidManifest.xml file using <activity>, <service> and <provider> tags.

If your activity is simply a parent class intended to be subclassed by other "real" activities, make it an abstract class.

More info: https://developer.android.com/guide/topics/manifest/manifest-intro.html

To suppress this error, use the issue id "Registered" as explained in the Suppressing Warnings and Errors section.

RequiredSize

Disabled By: Default

All views must specify an explicit layout_width and layout_height attribute. There is a runtime check for this, so if you fail to specify a size, an exception is thrown at runtime.

It's possible to specify these widths via styles as well. GridLayout, as a special case, does not require you to specify a size.
To suppress this error, use the issue id "RequiredSize" as explained in the Suppressing Warnings and Errors section.

SelectableText

Disabled By: Default

If a <TextView> is used to display data, the user might want to copy that data and paste it elsewhere. To allow this, the <TextView> should specify android:textIsSelectable="true".

This lint check looks for TextViews which are likely to be displaying data: views whose text is set dynamically. This value will be ignored on platforms older than API 11, so it is okay to set it regardless of your minSdkVersion.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "SelectableText" as explained in the Suppressing Warnings and Errors section.

StopShip

Disabled By: Default

Using the comment // STOPSHIP can be used to flag code that is incomplete but checked in. This comment marker can be used to indicate that the code should not be shipped until the issue is addressed, and lint will look for these. In Gradle projects, this is only checked for non-debug (release) builds.

In Kotlin, the TODO() method is also treated as a stop ship marker; you can use it to make incomplete code compile, but it will throw an exception at runtime and therefore should be fixed before shipping releases.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "StopShip" as explained in the Suppressing Warnings and Errors section.

SyntheticAccessor

Disabled By: Default

A private inner class which is accessed from the outer class will force the compiler to insert a synthetic accessor; this means that you are causing extra overhead. This is not important in small projects, but is important for large apps running up against the 64K method handle limit, and especially for libraries where you want to make sure your library is as small as possible for the cases where your library is used in an app running up against the 64K limit.
To suppress this error, use the issue id "SyntheticAccessor" as explained in the Suppressing Warnings and Errors section.

TypographyQuotes

Disabled By: Default

Straight single quotes and double quotes, when used as a pair, can be replaced by "curvy quotes" (or directional quotes). This can make the text more readable.

Note that you should never use grave accents and apostrophes to quote, `like this'.

(Also note that you should not use curvy quotes for code fragments.)

More info: https://en.wikipedia.org/wiki/Quotation_mark

Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "TypographyQuotes" as explained in the Suppressing Warnings and Errors section.

UnknownNullness

Disabled By: Default

To improve referencing this code from Kotlin, consider adding
explicit nullness information here with either @NonNull or @Nullable.

You can set the environment variable
ANDROID_LINT_NULLNESS_IGNORE_DEPRECATED=true
if you want lint to ignore classes and members that have been annotated with
@Deprecated.

More info: https://android.github.io/kotlin-guides/interop.html#nullability-annotations

To suppress this error, use the issue id "UnknownNullness" as explained in the Suppressing Warnings and Errors section.

UnpackedNativeCode

Disabled By: Default

This app loads native libraries using System.loadLibrary().

Consider adding android:extractNativeLibs="false" to the <application> tag in AndroidManifest.xml. Starting with Android 6.0, this will make installation faster, the app will take up less space on the device and updates will have smaller download sizes.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "UnpackedNativeCode" as explained in the Suppressing Warnings and Errors section.

UnsupportedChromeOsHardware

Disabled By: Default

The <uses-feature> element should not require this unsupported Chrome OS hardware feature. Any uses-feature not explicitly marked with required="false" is necessary on the device to be installed on. Ensure that any features that might prevent it from being installed on a Chrome OS device are reviewed and marked as not required in the manifest.

More info: https://developer.android.com/topic/arc/manifest.html#incompat-entries

Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "UnsupportedChromeOsHardware" as explained in the Suppressing Warnings and Errors section.

UnusedIds

Disabled By: Default

This resource id definition appears not to be needed since it is not referenced from anywhere. Having id definitions, even if unused, is not necessarily a bad idea since they make working on layouts and menus easier, so there is not a strong reason to delete these.

The unused resource check can ignore tests. If you want to include resources that are only referenced from tests, consider packaging them in a test source set instead.

You can include test sources in the unused resource check by setting the system property lint.unused-resources.include-tests=true, and to exclude them (usually for performance reasons), use lint.unused-resources.exclude-tests=true.
Note: This issue has an associated quickfix operation in Android Studio and IntelliJ IDEA.
To suppress this error, use the issue id "UnusedIds" as explained in the Suppressing Warnings and Errors section.

ValidActionsXml

Disabled By: Default

Ensures that an actions XML file is properly formed
To suppress this error, use the issue id "ValidActionsXml" as explained in the Suppressing Warnings and Errors section.

VectorPath

Disabled By: Command line flag

Using long vector paths is bad for performance. There are several ways to make the pathData shorter:
* Using less precision
* Removing some minor details
* Using the Android Studio vector conversion tool
* Rasterizing the image (converting to PNG)
To suppress this error, use the issue id "VectorPath" as explained in the Suppressing Warnings and Errors section.

WrongThreadInterprocedural

Disabled By: Default

Searches for interprocedural call paths that violate thread annotations in the program. Tracks the flow of instantiated types and lambda expressions to increase accuracy across method boundaries.

More info: https://developer.android.com/guide/components/processes-and-threads.html#Threads

To suppress this error, use the issue id "WrongThreadInterprocedural" as explained in the Suppressing Warnings and Errors section.

Suppressing Warnings and Errors

Lint errors can be suppressed in a variety of ways:

1. With a @SuppressLint annotation in the Java code
2. With a tools:ignore attribute in the XML file
3. With a //noinspection comment in the source code
4. With ignore flags specified in the build.gradle file, as explained below
5. With a lint.xml configuration file in the project
6. With a lint.xml configuration file passed to lint via the --config flag
7. With the --ignore flag passed to lint.

To suppress a lint warning with an annotation, add a @SuppressLint("id") annotation on the class, method or variable declaration closest to the warning instance you want to disable. The id can be one or more issue id's, such as "UnusedResources" or {"UnusedResources","UnusedIds"}, or it can be "all" to suppress all lint warnings in the given scope.

To suppress a lint warning with a comment, add a //noinspection id comment on the line before the statement with the error.

To suppress a lint warning in an XML file, add a tools:ignore="id" attribute on the element containing the error, or one of its surrounding elements. You also need to define the namespace for the tools prefix on the root element in your document, next to the xmlns:android declaration:
xmlns:tools="http://schemas.android.com/tools"

To suppress a lint warning in a build.gradle file, add a section like this:

android {
    lintOptions {
        disable 'TypographyFractions','TypographyQuotes'
    }
}

Here we specify a comma separated list of issue id's after the disable command. You can also use warning or error instead of disable to change the severity of issues.

To suppress lint warnings with a configuration XML file, create a file named lint.xml and place it at the root directory of the module in which it applies.

The format of the lint.xml file is something like the following:

<?xml version="1.0" encoding="UTF-8"?>
<lint>
    <!-- Ignore everything in the test source set -->
    <issue id="all">
        <ignore path="\*/test/\*" />
    </issue>

    <!-- Disable this given check in this project -->
    <issue id="IconMissingDensityFolder" severity="ignore" />

    <!-- Ignore the ObsoleteLayoutParam issue in the given files -->
    <issue id="ObsoleteLayoutParam">
        <ignore path="res/layout/activation.xml" />
        <ignore path="res/layout-xlarge/activation.xml" />
        <ignore regexp="(foo|bar)\.java" />
    </issue>

    <!-- Ignore the UselessLeaf issue in the given file -->
    <issue id="UselessLeaf">
        <ignore path="res/layout/main.xml" />
    </issue>

    <!-- Change the severity of hardcoded strings to "error" -->
    <issue id="HardcodedText" severity="error" />
</lint>

To suppress lint checks from the command line, pass the --ignore flag with a comma separated list of ids to be suppressed, such as:
$ lint --ignore UnusedResources,UselessLeaf /my/project/path

For more information, see https://developer.android.com/studio/write/lint.html#config